cswimr/revite
1
0
Fork 0
mirror of https://github.com/revoltchat/revite.git synced 2024-11-25 08:30:58 -05:00
Code Issues Projects Releases Packages Wiki Activity

fix(settings): close microphone access navigating away from page (#219)

Browse source 
Co-authored-by: Paul Makles <paulmakles@gmail.com>
This commit is contained in:
David Epely 2021-10-31 22:52:20 +01:00 committed by GitHub
parent d5c8749b80
commit 3ef3f84877
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/pages/settings/panes/Audio.tsx
View file

@ -29,11 +29,11 @@ export function Component() {
const askOrGetPermission = async () => {
try {
const mediaStream = await navigator.mediaDevices.getUserMedia(
const result = await navigator.mediaDevices.getUserMedia(
constraints,
);
setMediaStream(mediaStream);
setMediaStream(result);
} catch (err) {
// The user has blocked the permission
setError(err as DOMException);
@ -42,17 +42,28 @@ export function Component() {
try {
const { state } = await navigator.permissions.query({
// eslint-disable-next-line
// @ts-ignore
// @ts-ignore: very few browsers accept this `PermissionName`, but it has been drafted in https://www.w3.org/TR/permissions/#powerful-features-registry
name: "microphone",
});
setPermission(state);
} catch (err) {
// the browser might not support `query` functionnality
setError(err as DOMException);
// the browser might not support `query` functionnality or `PermissionName`
// nothing to do
}
};
useEffect(() => {
return () => {
if (mediaStream) {
// close microphone access on unmount
mediaStream.getTracks().forEach(track => {
track.stop()
})
}
}
}, [mediaStream]);
useEffect(() => {
if (!mediaStream) {
return;