From a6425cba3bacb9c7b1a69ab5300473eb2efd711f Mon Sep 17 00:00:00 2001
From: cswimr <seaswimmerthefsh@gmail.com>
Date: Sun, 8 Dec 2024 19:32:01 -0500
Subject: [PATCH] various `vscode` changes

- do not use fhsWithPackages - it causes issues with xonsh and is just generally not recommended unless absolutely necessary
- get dotnet/csharp extensions from nixpkgs
- get go extension from nixpkgs
- disable vscode's update and extension update checks
---
 home-manager/vscode.nix | 27 +++++++++++++++------------
 1 file changed, 15 insertions(+), 12 deletions(-)

diff --git a/home-manager/vscode.nix b/home-manager/vscode.nix
index a30be25..f5c4508 100644
--- a/home-manager/vscode.nix
+++ b/home-manager/vscode.nix
@@ -30,13 +30,16 @@ rec {
 
   programs.vscode = {
     enable = true;
-    package = pkgs.vscode.fhsWithPackages (
-      ps: with pkgs; [
-        dotnetCorePackages.sdk_8_0
-        jdk21
-        go
-      ]
-    );
+    enableUpdateCheck = false;
+    enableExtensionUpdateCheck = false;
+    package = pkgs.vscode;
+    # package = pkgs.vscode.fhsWithPackages (
+    #   ps: with pkgs; [
+    #     dotnetCorePackages.sdk_8_0
+    #     jdk21
+    #     go
+    #   ]
+    # );
     extensions =
       with inputs.nix-vscode-extensions.extensions.${system}.vscode-marketplace;
       with inputs.nix-vscode-extensions.extensions.${system}.vscode-marketplace-release;
@@ -64,10 +67,10 @@ rec {
         catppuccin.catppuccin-vsc-icons
 
         # C#
-        ms-dotnettools.csharp
-        ms-dotnettools.csdevkit
-        ms-dotnettools.vscodeintellicode-csharp
-        ms-dotnettools.vscode-dotnet-runtime
+        pkgs.vscode-extensions.ms-dotnettools.csharp
+        pkgs.vscode-extensions.ms-dotnettools.csdevkit
+        pkgs.vscode-extensions.ms-dotnettools.vscodeintellicode-csharp
+        pkgs.vscode-extensions.ms-dotnettools.vscode-dotnet-runtime
         csharpier.csharpier-vscode
         patcx.vscode-nuget-gallery
 
@@ -97,7 +100,7 @@ rec {
         nightrains.robloxlsp
 
         # Go
-        golang.go
+        pkgs.vscode-extensions.golang.go
 
         # Hugo
         budparr.language-hugo-vscode