From 24aa90bd9cf20b5c0d668552f9fffec942db3948 Mon Sep 17 00:00:00 2001
From: Lewis Crichton <lewi@lewisakura.moe>
Date: Sat, 25 Mar 2023 15:20:00 +0000
Subject: [PATCH] fix API plugins being force enabled unconditionally (#704)

* only enable dependencies if required

* fixme note
---
 src/plugins/index.ts | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/plugins/index.ts b/src/plugins/index.ts
index 6ac221da..d0d16c23 100644
--- a/src/plugins/index.ts
+++ b/src/plugins/index.ts
@@ -43,8 +43,11 @@ export function isPluginEnabled(p: string) {
 
 const pluginsValues = Object.values(Plugins);
 
-// First roundtrip to mark and force enable dependencies
-for (const p of pluginsValues) {
+// First roundtrip to mark and force enable dependencies (only for enabled plugins)
+//
+// FIXME: might need to revisit this if there's ever nested (dependencies of dependencies) dependencies since this only
+// goes for the top level and their children, but for now this works okay with the current API plugins
+for (const p of pluginsValues) if (settings[p.name]?.enabled) {
     p.dependencies?.forEach(d => {
         const dep = Plugins[d];
         if (dep) {