update docs and bump @actions/artifact

.github/workflows/check-dist.yml

@@ -10,9 +10,11 @@ on:
   push:
     branches:
       - main
+    paths-ignore:
+      - '**.md'
   pull_request:
-    branches:
+    paths-ignore:
-      - main
+      - '**.md'
   workflow_dispatch:
 
 jobs:
@@ -20,33 +22,32 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
-      - name: Setup Node 16
+      - name: Setup Node 20
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 16.x
+          node-version: 20.x
           cache: 'npm'
 
       - name: Install dependencies
         run: npm ci
 
-      - name: Move the committed index.js file
+      - name: Rebuild the dist/ directory
-        run: mv dist/index.js /tmp
-
-      - name: Rebuild with tsc
         run: npm run build
 
-      - name: Rebuild the index.js file
+      - name: Compare the expected and actual dist/ directories
-        run: npm run release
+        run: |
-
+          if [ "$(git diff --ignore-space-at-eol dist/ | wc -l)" -gt "0" ]; then
-      - name: Compare the expected and actual index.js files
+            echo "Detected uncommitted changes after build.  See status below:"
-        run: git diff --ignore-all-space dist/index.js /tmp/index.js
+            git diff
+            exit 1
+          fi
         id: diff
 
       # If index.js was different than expected, upload the expected version as an artifact
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4-beta
         if: ${{ failure() && steps.diff.conclusion == 'failure' }}
         with:
-          name: index.js
+          name: dist
-          path: dist/index.js
+          path: dist/

.github/workflows/licensed.yml

@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     name: Check licenses
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - run: npm ci
       - name: Install licensed
         run: |

.github/workflows/test.yml

@@ -1,4 +1,5 @@
 name: Test
+
 on:
   push:
     branches:
@@ -10,7 +11,6 @@ on:
       - '**.md'
 
 jobs:
-
   build:
     name: Build
 
@@ -23,12 +23,12 @@ jobs:
 
     steps:
     - name: Checkout
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
-    - name: Setup Node 16
+    - name: Setup Node 20
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
-        node-version: 16.x
+        node-version: 20.x
         cache: 'npm'
 
     - name: Install dependencies
@@ -54,33 +54,26 @@ jobs:
         mkdir -p path/to/dir-3
         echo "Lorem ipsum dolor sit amet" > path/to/dir-1/file1.txt
         echo "Hello world from file #2" > path/to/dir-2/file2.txt
-        echo "This is a going to be a test for a large enough file that should get compressed with GZip. The @actions/artifact package uses GZip to upload files. This text should have a compression ratio greater than 100% so it should get uploaded using GZip" > path/to/dir-3/gzip.txt
 
     # Upload a single file artifact
     - name: 'Upload artifact #1'
       uses: ./
       with:
-        name: 'Artifact-A'
+        name: 'Artifact-A-${{ matrix.runs-on }}'
         path: path/to/dir-1/file1.txt
 
-    # Upload using a wildcard pattern, name should default to 'artifact' if not provided
+    # Upload using a wildcard pattern
     - name: 'Upload artifact #2'
       uses: ./
       with:
+        name: 'Artifact-Wildcard-${{ matrix.runs-on }}'
         path: path/**/dir*/
 
-    # Upload a directory that contains a file that will be uploaded with GZip
+    # Upload a multi-path artifact
     - name: 'Upload artifact #3'
       uses: ./
       with:
-        name: 'GZip-Artifact'
+        name: 'Multi-Path-Artifact-${{ matrix.runs-on }}'
-        path: path/to/dir-3/
-
-    # Upload a directory that contains a file that will be uploaded with GZip
-    - name: 'Upload artifact #4'
-      uses: ./
-      with:
-        name: 'Multi-Path-Artifact'
         path: |
           path/to/dir-1/*
           path/to/dir-[23]/*
@@ -88,9 +81,9 @@ jobs:
 
     # Download Artifact #1 and verify the correctness of the content
     - name: 'Download artifact #1'
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4-beta
       with:
-        name: 'Artifact-A'
+        name: 'Artifact-A-${{ matrix.runs-on }}'
         path: some/new/path
 
     - name: 'Verify Artifact #1'
@@ -108,9 +101,9 @@ jobs:
 
     # Download Artifact #2 and verify the correctness of the content
     - name: 'Download artifact #2'
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4-beta
       with:
-        name: 'artifact'
+        name: 'Artifact-Wildcard-${{ matrix.runs-on }}'
         path: some/other/path
 
     - name: 'Verify Artifact #2'
@@ -127,31 +120,11 @@ jobs:
         }
       shell: pwsh
 
-    # Download Artifact #3 and verify the correctness of the content
+    # Download Artifact #4 and verify the correctness of the content
-    - name: 'Download artifact #3'
-      uses: actions/download-artifact@v3
-      with:
-        name: 'GZip-Artifact'
-        path: gzip/artifact/path
-
-    # Because a directory was used as input during the upload the parent directories, path/to/dir-3/, should not be included in the uploaded artifact
-    - name: 'Verify Artifact #3'
-      run: |
-        $gzipFile = "gzip/artifact/path/gzip.txt"
-        if(!(Test-Path -path $gzipFile))
-        {
-            Write-Error "Expected file do not exist"
-        }
-        if(!((Get-Content $gzipFile) -ceq "This is a going to be a test for a large enough file that should get compressed with GZip. The @actions/artifact package uses GZip to upload files. This text should have a compression ratio greater than 100% so it should get uploaded using GZip"))
-        {
-            Write-Error "File contents of downloaded artifact is incorrect"
-        }
-      shell: pwsh
-
     - name: 'Download artifact #4'
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4-beta
       with:
-        name: 'Multi-Path-Artifact'
+        name: 'Multi-Path-Artifact-${{ matrix.runs-on }}'
         path: multi/artifact
 
     - name: 'Verify Artifact #4'

README.md

@@ -1,34 +1,107 @@
-# Upload-Artifact v4 beta
+# `@actions/download-artifact`
 
-❗ Not publicly available. If you try to use this version then it will fail. Available only internally at GitHub while in development. Stay tuned for public announcements soon about broader availability❗
+Upload [Actions Artifacts](https://docs.github.com/en/actions/using-workflows/storing-workflow-data-as-artifacts) from your Workflow Runs. Internally powered by [@actions/artifact](https://github.com/actions/toolkit/tree/main/packages/artifact) package.
-
-This uploads artifacts from your workflow allowing you to share data between jobs and store data once a workflow is complete.
 
 See also [download-artifact](https://github.com/actions/download-artifact).
 
-# What's new
+- [`@actions/download-artifact`](#actionsdownload-artifact)
+  - [v4 - What's new](#v4---whats-new)
+    - [Improvements](#improvements)
+    - [Breaking Changes](#breaking-changes)
+  - [Usage](#usage)
+    - [Inputs](#inputs)
+    - [Outputs](#outputs)
+  - [Examples](#examples)
+    - [Upload an Individual File](#upload-an-individual-file)
+    - [Upload an Entire Directory](#upload-an-entire-directory)
+    - [Upload using a Wildcard Pattern](#upload-using-a-wildcard-pattern)
+    - [Upload using Multiple Paths and Exclusions](#upload-using-multiple-paths-and-exclusions)
+    - [Customization if no files are found](#customization-if-no-files-are-found)
+    - [(Not) Uploading to the same artifact](#not-uploading-to-the-same-artifact)
+    - [Environment Variables and Tilde Expansion](#environment-variables-and-tilde-expansion)
+    - [Retention Period](#retention-period)
+    - [Using Outputs](#using-outputs)
+      - [Example output between steps](#example-output-between-steps)
+      - [Example output between jobs](#example-output-between-jobs)
+  - [Where does the upload go?](#where-does-the-upload-go)
+  - [Additional Documentation](#additional-documentation)
 
-🚧 Under construction 🚧
 
-Big changes coming...
+## v4 - What's new
 
-Refer [here](https://github.com/actions/upload-artifact/tree/releases/v3) for the previous version
+> [!IMPORTANT]
+> upload-artifact@v4+ is not currently supported on GHES yet. If you are on GHES, you must use [v3](https://github.com/actions/upload-artifact/releases/tag/v3).
 
-# Usage
+The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.
 
-See [action.yml](action.yml)
+For more information, see the [`@actions/artifact`](https://github.com/actions/toolkit/tree/main/packages/artifact) documentation.
+
+### Improvements
+
+1. Uploads are significantly faster, upwards of 90% improvement in worst case scenarios.
+2. Once uploaded, an Artifact ID is returned and Artifacts are immediately available in the UI and [REST API](https://docs.github.com/en/rest/actions/artifacts). Previously, you would have to wait for the run to be completed before an ID was available or any APIs could be utilized.
+3. The contents of an Artifact are uploaded together into an _immutable_ archive. They cannot be altered by subsequent jobs. Both of these factors help reduce the possibility of accidentally corrupting Artifact files.
+
+### Breaking Changes
+
+1. On self hosted runners, additional [firewall rules](https://github.com/actions/toolkit/tree/main/packages/artifact#breaking-changes) may be required.
+2. Uploading to the same named Artifact multiple times.
+
+    Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once. Otherwise you _will_ encounter an error.
+
+3. Limit of Artifacts for an individual job. Each job in a workflow run now has a limit of 10 artifacts.
+
+## Usage
+
+### Inputs
+
+```yaml
+- uses: actions/download-artifact@v4
+  with:
+    # Name of the artifact to upload.
+    # Optional. Default is 'artifact'
+    name:
+
+    # A file, directory or wildcard pattern that describes what to upload
+    # Required.
+    path:
+
+    # The desired behavior if no files are found using the provided path.
+    # Available Options:
+    #   warn: Output a warning but do not fail the action
+    #   error: Fail the action with an error message
+    #   ignore: Do not output any warnings or errors, the action does not fail
+    # Optional. Default is 'warn'
+    if-no-files-found:
+
+    # Duration after which artifact will expire in days. 0 means using default retention.
+    # Minimum 1 day.
+    # Maximum 90 days unless changed from the repository settings page.
+    # Optional. Defaults to repository settings.
+    retention-days:
+
+    # The level of compression for Zlib to be applied to the artifact archive.
+    # The value can range from 0 to 9.
+    # For large files that are not easily compressed, a value of 0 is recommended for significantly faster uploads.
+    # Optional. Default is '6'
+    compression-level:
+```
+
+### Outputs
+
+| Name | Description | Example |
+| - | - | - |
+| `artifact-id` | GitHub ID of an Artifact, can be used by the REST API | `1234` |
+
+## Examples
 
 ### Upload an Individual File
 
 ```yaml
 steps:
-- uses: actions/checkout@v3
-
 - run: mkdir -p path/to/artifact
-
 - run: echo hello > path/to/artifact/world.txt
-
+- uses: actions/upload-artifact@v4
-- uses: actions/upload-artifact@v4-beta
   with:
     name: my-artifact
     path: path/to/artifact/world.txt
@@ -37,7 +110,7 @@ steps:
 ### Upload an Entire Directory
 
 ```yaml
-- uses: actions/upload-artifact@v4-beta
+- uses: actions/upload-artifact@v4
   with:
     name: my-artifact
     path: path/to/artifact/ # or path/to/artifact
@@ -46,7 +119,7 @@ steps:
 ### Upload using a Wildcard Pattern
 
 ```yaml
-- uses: actions/upload-artifact@v4-beta
+- uses: actions/upload-artifact@v4
   with:
     name: my-artifact
     path: path/**/[abc]rtifac?/*
@@ -55,7 +128,7 @@ steps:
 ### Upload using Multiple Paths and Exclusions
 
 ```yaml
-- uses: actions/upload-artifact@v4-beta
+- uses: actions/upload-artifact@v4
   with:
     name: my-artifact
     path: |
@@ -84,8 +157,6 @@ If multiple paths are provided as input, the least common ancestor of all the se
 
 Relative and absolute file paths are both allowed. Relative paths are rooted against the current working directory. Paths that begin with a wildcard character should be quoted to avoid being interpreted as YAML aliases.
 
-The [@actions/artifact](https://github.com/actions/toolkit/tree/main/packages/artifact) package is used internally to handle most of the logic around uploading an artifact. There is extra documentation around upload limitations and behavior in the toolkit repo that is worth checking out.
-
 ### Customization if no files are found
 
 If a path (or paths), result in no files being found for the artifact, the action will succeed but print out a warning. In certain scenarios it may be desirable to fail the action or suppress the warning. The `if-no-files-found` option allows you to customize the behavior of the action if no files are found:
@@ -98,31 +169,7 @@ If a path (or paths), result in no files being found for the artifact, the actio
     if-no-files-found: error # 'warn' or 'ignore' are also available, defaults to `warn`
 ```
 
-### Conditional Artifact Upload
+### (Not) Uploading to the same artifact
-
-To upload artifacts only when the previous step of a job failed, use [`if: failure()`](https://help.github.com/en/articles/contexts-and-expression-syntax-for-github-actions#job-status-check-functions):
-
-```yaml
-- uses: actions/upload-artifact@v4-beta
-  if: failure()
-  with:
-    name: my-artifact
-    path: path/to/artifact/
-```
-
-### Uploading without an artifact name
-
-You can upload an artifact without specifying a name
-
-```yaml
-- uses: actions/upload-artifact@v4-beta
-  with:
-    path: path/to/artifact/world.txt
-```
-
-If not provided, `artifact` will be used as the default name which will manifest itself in the UI after upload.
-
-### Uploading to the same artifact
 
 Unlike earlier versions of `upload-artifact`, uploading to the same artifact via multiple jobs is _not_ supported with `v4`.
 
@@ -130,16 +177,46 @@ Unlike earlier versions of `upload-artifact`, uploading to the same artifact via
 - run: echo hi > world.txt
 - uses: actions/upload-artifact@v4-beta
   with:
+    # implicitly named as 'artifact'
     path: world.txt
 
 - run: echo howdy > extra-file.txt
 - uses: actions/upload-artifact@v4-beta
   with:
+    # also implicitly named as 'artifact', will fail here!
     path: extra-file.txt
 ```
 
 Artifact names must be unique since each created artifact is idempotent so multiple jobs cannot modify the same artifact.
 
+In matrix scenarios, be careful to not accidentally upload to the same artifact, or else you will encounter conflict errors. It would be best to name the artifact _with_ a prefix or suffix from the matrix:
+
+```yaml
+jobs:
+  upload:
+    name: Generate Build Artifacts
+
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest]
+        version: [a, b, c]
+
+    runs-on: ${{ matrix.os }}
+
+    steps:
+    - name: Build
+      run: ./some-script --version=${{ matrix.version }} > my-binary
+    - name: Upload
+      uses: actions/upload-artifact@v4
+      with:
+        name: binary-${{ matrix.os }}-${{ matrix.version }}
+        path: my-binary
+```
+
+This will result in artifacts like: `binary-ubuntu-latest-a`, `binary-windows-latest-b`, and so on.
+
+Previously the behavior _allowed_ for the artifact names to be the same which resulted in unexpected mutations and accidental corruption. Artifacts created by upload-artifact@v4 will be immutable.
+
 ### Environment Variables and Tilde Expansion
 
 You can use `~` in the path input as a substitute for `$HOME`. Basic tilde expansion is supported:
@@ -201,11 +278,11 @@ Artifacts are retained for 90 days by default. You can specify a shorter retenti
 
 The retention period must be between 1 and 90 inclusive. For more information see [artifact and log retention policies](https://docs.github.com/en/free-pro-team@latest/actions/reference/usage-limits-billing-and-administration#artifact-and-log-retention-policy).
 
-## Outputs
+### Using Outputs
 
 If an artifact upload is successful then an `artifact-id` output is available. This ID is a unique identifier that can be used with [Artifact REST APIs](https://docs.github.com/en/rest/actions/artifacts).
 
-### Example output between steps
+#### Example output between steps
 
 ```yml
     - uses: actions/upload-artifact@v4-beta
@@ -218,7 +295,7 @@ If an artifact upload is successful then an `artifact-id` output is available. T
       run:  echo 'Artifact ID is ${{ steps.artifact-upload-step.outputs.artifact-id }}'
 ```
 
-### Example output between jobs
+#### Example output between jobs
 
 ```yml
 jobs:
@@ -257,6 +334,3 @@ See [Storing workflow data as artifacts](https://docs.github.com/en/actions/adva
 
 See extra documentation for the [@actions/artifact](https://github.com/actions/toolkit/blob/main/packages/artifact/docs/additional-information.md) package that is used internally regarding certain behaviors and limitations.
 
-# License
-
-The scripts and documentation in this project are released under the [MIT License](LICENSE).

package.json

@@ -1,7 +1,7 @@
 {
   "name": "upload-artifact",
-  "version": "3.0.0",
+  "version": "4.0.0",
-  "description": "Upload a build artifact that can be used by subsequent workflow steps",
+  "description": "Upload an Actions Artifact in a workflow run",
   "main": "dist/index.js",
   "scripts": {
     "build": "tsc",