Merge pull request #1102 from epage/template
Some checks failed
Security audit / security_audit (push) Has been cancelled
Security audit / cargo_deny (bans licenses sources) (push) Has been cancelled
CI / Test (push) Has been cancelled
CI / Check MSRV (push) Has been cancelled
CI / lockfile (push) Has been cancelled
CI / Docs (push) Has been cancelled
CI / rustfmt (push) Has been cancelled
CI / clippy (push) Has been cancelled
CI / Coverage (push) Has been cancelled
/ linux (aarch64) (push) Has been cancelled
/ linux (x86) (push) Has been cancelled
/ linux (x86_64) (push) Has been cancelled
/ musllinux (aarch64) (push) Has been cancelled
/ musllinux (x86_64) (push) Has been cancelled
/ windows (x64) (push) Has been cancelled
/ windows (x86) (push) Has been cancelled
/ macos (aarch64) (push) Has been cancelled
/ macos (x86_64) (push) Has been cancelled
/ sdist (push) Has been cancelled
pre-commit / pre-commit (push) Has been cancelled
CI / CI (push) Has been cancelled
/ Release (push) Has been cancelled

chore: Update from _rust template
This commit is contained in:
Ed Page 2024-09-27 14:47:30 -04:00 committed by GitHub
commit 977faa8c94
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 1 deletions

View file

@ -24,4 +24,6 @@ jobs:
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
- uses: actions/setup-python@v5 - uses: actions/setup-python@v5
with:
python-version: '3.x'
- uses: pre-commit/action@v3.0.1 - uses: pre-commit/action@v3.0.1

View file

@ -78,7 +78,7 @@ We ask that commits are atomic, meaning they are complete and have a single resp
PRs should tell a cohesive story, with test and refactor commits that keep the PRs should tell a cohesive story, with test and refactor commits that keep the
fix or feature commits simple and clear. fix or feature commits simple and clear.
Specifically, we would encouage Specifically, we would encourage
- File renames be isolated into their own commit - File renames be isolated into their own commit
- Add tests in a commit before their feature or fix, showing the current behavior. - Add tests in a commit before their feature or fix, showing the current behavior.
The diff for the feature/fix commit will then show how the behavior changed, The diff for the feature/fix commit will then show how the behavior changed,