mirror of
https://github.com/super-linter/super-linter.git
synced 2024-11-13 20:39:33 -05:00
91dc6d7234
- Add missing fix mode options for: CLANG_FORMAT, ENV, GOOGLE_JAVA_FORMAT, NATURAL_LANGUAGE, PYTHON_ISORT, RUST_CLIPPY. - Refactor linter tests to make them shorter because there's no need to have big test files. - Refactor 'bad' linter tests for linters that support fix mode so they contain only automatically fixable issues. This is needed to avoid adding another set of 'bad' linter tests for fix mode. - Provide configuration files for linters that support fix mode and for which the default configuration is not suitable to enable fix mode: ansible-lint, ESLint, golangci-lint. - Add a test case for linter commands options for linters that support fix mode, to ensure that fix mode and check-only mode options have been defined. - Refactor the fix mode test to check if linters actually applied modifications to files. - Update documentation about adding test cases for linters that support fix mode. - Don't exit with a fatal error if VALIDATE_xxx is false when testing fix mode because not all linters support fix mode. To enable this, set the new FIX_MODE_TEST_CASE_RUN variable to true.
251 lines
10 KiB
Bash
Executable file
251 lines
10 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
|
|
function LintCodebase() {
|
|
local FILE_TYPE
|
|
FILE_TYPE="${1}" && shift
|
|
local TEST_CASE_RUN
|
|
TEST_CASE_RUN="${1}" && shift
|
|
|
|
declare -n VALIDATE_LANGUAGE
|
|
VALIDATE_LANGUAGE="VALIDATE_${FILE_TYPE}"
|
|
|
|
if [[ "${VALIDATE_LANGUAGE}" == "false" ]]; then
|
|
if [[ "${TEST_CASE_RUN}" == "false" ]]; then
|
|
debug "Skip validation of ${FILE_TYPE} because VALIDATE_LANGUAGE is ${VALIDATE_LANGUAGE}"
|
|
unset -n VALIDATE_LANGUAGE
|
|
return 0
|
|
else
|
|
if [[ "${FIX_MODE_TEST_CASE_RUN}" == "true" ]]; then
|
|
debug "Don't fail the test even if VALIDATE_${FILE_TYPE} is set to ${VALIDATE_LANGUAGE} because ${FILE_TYPE} might not support fix mode"
|
|
return 0
|
|
else
|
|
fatal "Don't disable any validation when running in test mode. VALIDATE_${FILE_TYPE} is set to: ${VALIDATE_LANGUAGE}. Set it to: true"
|
|
fi
|
|
fi
|
|
fi
|
|
|
|
debug "Running LintCodebase. FILE_TYPE: ${FILE_TYPE}. TEST_CASE_RUN: ${TEST_CASE_RUN}"
|
|
|
|
debug "VALIDATE_LANGUAGE for ${FILE_TYPE}: ${VALIDATE_LANGUAGE}..."
|
|
|
|
ValidateBooleanVariable "TEST_CASE_RUN" "${TEST_CASE_RUN}"
|
|
ValidateBooleanVariable "VALIDATE_${FILE_TYPE}" "${VALIDATE_LANGUAGE}"
|
|
|
|
unset -n VALIDATE_LANGUAGE
|
|
|
|
debug "Populating file array for ${FILE_TYPE}"
|
|
local -n FILE_ARRAY="FILE_ARRAY_${FILE_TYPE}"
|
|
local FILE_ARRAY_LANGUAGE_PATH="${FILE_ARRAYS_DIRECTORY_PATH}/file-array-${FILE_TYPE}"
|
|
if [[ -e "${FILE_ARRAY_LANGUAGE_PATH}" ]]; then
|
|
while read -r FILE; do
|
|
if [[ "${TEST_CASE_RUN}" == "true" ]]; then
|
|
debug "Ensure that the list files to check for ${FILE_TYPE} doesn't include test cases for other languages"
|
|
# Folder for specific tests. By convention, the last part of the path is the lowercased FILE_TYPE
|
|
local TEST_CASE_DIRECTORY
|
|
TEST_CASE_DIRECTORY="${FILE_TYPE,,}"
|
|
|
|
# We use configuration files to pass the list of files to lint to checkov
|
|
# Their name includes "checkov", which is equal to FILE_TYPE for Checkov.
|
|
# In this case, we don't add a trailing slash so we don't fail validation.
|
|
if [[ "${FILE_TYPE}" != "CHECKOV" ]]; then
|
|
TEST_CASE_DIRECTORY="${TEST_CASE_DIRECTORY}/"
|
|
debug "Adding a traling slash to the test case directory for ${FILE_TYPE}: ${TEST_CASE_DIRECTORY}"
|
|
fi
|
|
|
|
debug "TEST_CASE_DIRECTORY for ${FILE_TYPE}: ${TEST_CASE_DIRECTORY}"
|
|
if [[ ${FILE} != *"${TEST_CASE_DIRECTORY}"* ]]; then
|
|
debug "Excluding ${FILE} because it's not in the test case directory for ${FILE_TYPE}..."
|
|
continue
|
|
else
|
|
debug "Including ${FILE} because it's a test case for ${FILE_TYPE}"
|
|
fi
|
|
fi
|
|
FILE_ARRAY+=("${FILE}")
|
|
done <"${FILE_ARRAY_LANGUAGE_PATH}"
|
|
else
|
|
debug "${FILE_ARRAY_LANGUAGE_PATH} doesn't exist. Skip loading the list of files and directories to lint for ${FILE_TYPE}"
|
|
fi
|
|
|
|
if [[ "${#FILE_ARRAY[@]}" -eq 0 ]]; then
|
|
if [[ "${TEST_CASE_RUN}" == "false" ]]; then
|
|
debug "There are no items to lint for ${FILE_TYPE}"
|
|
unset -n FILE_ARRAY
|
|
return 0
|
|
else
|
|
fatal "Cannot find any tests for ${FILE_TYPE}"
|
|
fi
|
|
else
|
|
debug "There are ${#FILE_ARRAY[@]} items to lint for ${FILE_TYPE}: ${FILE_ARRAY[*]}"
|
|
fi
|
|
|
|
startGitHubActionsLogGroup "${FILE_TYPE}"
|
|
|
|
info "Linting ${FILE_TYPE} items..."
|
|
|
|
local PARALLEL_RESULTS_FILE_PATH
|
|
PARALLEL_RESULTS_FILE_PATH="${SUPER_LINTER_PRIVATE_OUTPUT_DIRECTORY_PATH}/super-linter-worker-results-${FILE_TYPE}.json"
|
|
debug "PARALLEL_RESULTS_FILE_PATH for ${FILE_TYPE}: ${PARALLEL_RESULTS_FILE_PATH}"
|
|
|
|
local -a PARALLEL_COMMAND
|
|
PARALLEL_COMMAND=(parallel --will-cite --keep-order --max-procs "$(($(nproc) * 1))" --xargs --results "${PARALLEL_RESULTS_FILE_PATH}")
|
|
|
|
if [ "${LOG_DEBUG}" == "true" ]; then
|
|
debug "LOG_DEBUG is enabled. Enable verbose ouput for parallel"
|
|
PARALLEL_COMMAND+=(--verbose)
|
|
fi
|
|
debug "PARALLEL_COMMAND for ${FILE_TYPE}: ${PARALLEL_COMMAND[*]}"
|
|
|
|
# The following linters support linting one file at a time, and don't support linting a list of files,
|
|
# so we cannot pass more than one file per invocation
|
|
if [[ "${FILE_TYPE}" == "ANSIBLE" ]] ||
|
|
[[ "${FILE_TYPE}" == "ARM" ]] ||
|
|
[[ "${FILE_TYPE}" == "BASH_EXEC" ]] ||
|
|
[[ "${FILE_TYPE}" == "CLOJURE" ]] ||
|
|
[[ "${FILE_TYPE}" == "CSHARP" ]] ||
|
|
[[ "${FILE_TYPE}" == "GITLEAKS" ]] ||
|
|
[[ "${FILE_TYPE}" == "GO_MODULES" ]] ||
|
|
[[ "${FILE_TYPE}" == "JSCPD" ]] ||
|
|
[[ "${FILE_TYPE}" == "KOTLIN" ]] ||
|
|
[[ "${FILE_TYPE}" == "SQL" ]] ||
|
|
[[ "${FILE_TYPE}" == "SQLFLUFF" ]] ||
|
|
[[ "${FILE_TYPE}" == "CHECKOV" ]] ||
|
|
[[ "${FILE_TYPE}" == "POWERSHELL" ]] ||
|
|
[[ "${FILE_TYPE}" == "R" ]] ||
|
|
[[ "${FILE_TYPE}" == "RUST_CLIPPY" ]] ||
|
|
[[ "${FILE_TYPE}" == "SNAKEMAKE_LINT" ]] ||
|
|
[[ "${FILE_TYPE}" == "STATES" ]] ||
|
|
[[ "${FILE_TYPE}" == "TERRAFORM_TFLINT" ]] ||
|
|
[[ "${FILE_TYPE}" == "TERRAFORM_TERRASCAN" ]] ||
|
|
[[ "${FILE_TYPE}" == "TERRAGRUNT" ]]; then
|
|
debug "${FILE_TYPE} doesn't support linting files in batches. Configure the linter to run over the files to lint one by one"
|
|
PARALLEL_COMMAND+=(--max-lines 1)
|
|
fi
|
|
debug "PARALLEL_COMMAND for ${FILE_TYPE} after updating the number of files to lint per process: ${PARALLEL_COMMAND[*]}"
|
|
|
|
local LINTER_WORKING_DIRECTORY
|
|
LINTER_WORKING_DIRECTORY="${GITHUB_WORKSPACE}"
|
|
|
|
# GNU parallel parameter expansion:
|
|
# - {} input item
|
|
# - {/} basename of the input lint
|
|
# - {//} dirname of input line
|
|
|
|
if [[ ${FILE_TYPE} == "CSHARP" ]] ||
|
|
[[ (${FILE_TYPE} == "R" && -f "$(dirname "${FILE}")/.lintr") ]] ||
|
|
[[ ${FILE_TYPE} == "KOTLIN" ]] ||
|
|
[[ ${FILE_TYPE} == "RUST_CLIPPY" ]] ||
|
|
[[ ${FILE_TYPE} == "TERRAFORM_TFLINT" ]]; then
|
|
LINTER_WORKING_DIRECTORY="{//}"
|
|
elif [[ ${FILE_TYPE} == "ANSIBLE" ]] ||
|
|
[[ ${FILE_TYPE} == "GO_MODULES" ]]; then
|
|
LINTER_WORKING_DIRECTORY="{}"
|
|
fi
|
|
|
|
debug "LINTER_WORKING_DIRECTORY for ${FILE_TYPE}: ${LINTER_WORKING_DIRECTORY}"
|
|
PARALLEL_COMMAND+=(--workdir "${LINTER_WORKING_DIRECTORY}")
|
|
debug "PARALLEL_COMMAND for ${FILE_TYPE} after updating the working directory: ${PARALLEL_COMMAND[*]}"
|
|
|
|
# shellcheck source=/dev/null
|
|
source /action/lib/functions/linterCommands.sh
|
|
# Dynamically add arguments and commands to each linter command as needed
|
|
if ! InitFixModeOptionsAndCommands "${FILE_TYPE}"; then
|
|
fatal "Error while inizializing fix mode and check only options and commands before running linter for ${FILE_TYPE}"
|
|
fi
|
|
InitInputConsumeCommands
|
|
|
|
if [[ "${FILE_TYPE}" == "POWERSHELL" ]]; then
|
|
debug "Language: ${FILE_TYPE}. Initialize PowerShell command"
|
|
InitPowerShellCommand
|
|
fi
|
|
|
|
local -n LINTER_COMMAND_ARRAY
|
|
LINTER_COMMAND_ARRAY="LINTER_COMMANDS_ARRAY_${FILE_TYPE}"
|
|
if [ ${#LINTER_COMMAND_ARRAY[@]} -eq 0 ]; then
|
|
fatal "LINTER_COMMAND_ARRAY for ${FILE_TYPE} is empty."
|
|
else
|
|
debug "LINTER_COMMAND_ARRAY for ${FILE_TYPE} has ${#LINTER_COMMAND_ARRAY[@]} elements: ${LINTER_COMMAND_ARRAY[*]}"
|
|
fi
|
|
|
|
PARALLEL_COMMAND+=("${LINTER_COMMAND_ARRAY[@]}")
|
|
debug "PARALLEL_COMMAND for ${FILE_TYPE} after LINTER_COMMAND_ARRAY concatenation: ${PARALLEL_COMMAND[*]}"
|
|
|
|
unset -n LINTER_COMMAND_ARRAY
|
|
|
|
local PARALLEL_COMMAND_OUTPUT
|
|
local PARALLEL_COMMAND_RETURN_CODE
|
|
PARALLEL_COMMAND_OUTPUT=$(printf "%s\n" "${FILE_ARRAY[@]}" | "${PARALLEL_COMMAND[@]}" 2>&1)
|
|
# Don't check for errors on this return code because commands can fail if linter report errors
|
|
PARALLEL_COMMAND_RETURN_CODE=$?
|
|
debug "PARALLEL_COMMAND_OUTPUT for ${FILE_TYPE} (exit code: ${PARALLEL_COMMAND_RETURN_CODE}): ${PARALLEL_COMMAND_OUTPUT}"
|
|
debug "Parallel output file (${PARALLEL_RESULTS_FILE_PATH}) contents for ${FILE_TYPE}:\n$(cat "${PARALLEL_RESULTS_FILE_PATH}")"
|
|
|
|
echo ${PARALLEL_COMMAND_RETURN_CODE} >"${SUPER_LINTER_PRIVATE_OUTPUT_DIRECTORY_PATH}/super-linter-parallel-command-exit-code-${FILE_TYPE}"
|
|
|
|
if [ ${PARALLEL_COMMAND_RETURN_CODE} -ne 0 ]; then
|
|
error "Found errors when linting ${FILE_TYPE}. Exit code: ${PARALLEL_COMMAND_RETURN_CODE}."
|
|
else
|
|
notice "${FILE_TYPE} linted successfully"
|
|
fi
|
|
|
|
local RESULTS_OBJECT
|
|
RESULTS_OBJECT=
|
|
if ! RESULTS_OBJECT=$(jq --raw-output -n '[inputs]' "${PARALLEL_RESULTS_FILE_PATH}"); then
|
|
fatal "Error loading results for ${FILE_TYPE}: ${RESULTS_OBJECT}"
|
|
fi
|
|
debug "RESULTS_OBJECT for ${FILE_TYPE}:\n${RESULTS_OBJECT}"
|
|
|
|
# To count how many files were checked for a given FILE_TYPE
|
|
local INDEX
|
|
INDEX=0
|
|
if ! ((INDEX = $(jq '[.[] | .V | length] | add' <<<"${RESULTS_OBJECT}"))); then
|
|
fatal "Error when setting INDEX for ${FILE_TYPE}: ${INDEX}"
|
|
fi
|
|
debug "Set INDEX for ${FILE_TYPE} to: ${INDEX}"
|
|
|
|
local STDOUT_LINTER
|
|
# Get raw output so we can strip quotes from the data we load. Also, strip the final newline to avoid adding it two times
|
|
if ! STDOUT_LINTER="$(jq --raw-output '.[] | select(.Stdout[:-1] | length > 0) | .Stdout[:-1]' <<<"${RESULTS_OBJECT}")"; then
|
|
fatal "Error when loading stdout for ${FILE_TYPE}:\n${STDOUT_LINTER}"
|
|
fi
|
|
|
|
if [ -n "${STDOUT_LINTER}" ]; then
|
|
local STDOUT_LINTER_LOG_MESSAGE
|
|
STDOUT_LINTER_LOG_MESSAGE="Command output for ${FILE_TYPE}:\n------\n${STDOUT_LINTER}\n------"
|
|
info "${STDOUT_LINTER_LOG_MESSAGE}"
|
|
|
|
if [ ${PARALLEL_COMMAND_RETURN_CODE} -ne 0 ]; then
|
|
local STDOUT_LINTER_FILE_PATH
|
|
STDOUT_LINTER_FILE_PATH="${SUPER_LINTER_PRIVATE_OUTPUT_DIRECTORY_PATH}/super-linter-parallel-stdout-${FILE_TYPE}"
|
|
debug "Saving stdout for ${FILE_TYPE} to ${STDOUT_LINTER_FILE_PATH} in case we need it later"
|
|
printf '%s\n' "${STDOUT_LINTER_LOG_MESSAGE}" >"${STDOUT_LINTER_FILE_PATH}"
|
|
fi
|
|
else
|
|
debug "Stdout for ${FILE_TYPE} is empty"
|
|
fi
|
|
|
|
local STDERR_LINTER
|
|
if ! STDERR_LINTER="$(jq --raw-output '.[] | select(.Stderr[:-1] | length > 0) | .Stderr[:-1]' <<<"${RESULTS_OBJECT}")"; then
|
|
fatal "Error when loading stderr for ${FILE_TYPE}:\n${STDERR_LINTER}"
|
|
fi
|
|
|
|
if [ -n "${STDERR_LINTER}" ]; then
|
|
local STDERR_LINTER_LOG_MESSAGE
|
|
STDERR_LINTER_LOG_MESSAGE="Stderr contents for ${FILE_TYPE}:\n------\n${STDERR_LINTER}\n------"
|
|
info "${STDERR_LINTER_LOG_MESSAGE}"
|
|
if [ ${PARALLEL_COMMAND_RETURN_CODE} -ne 0 ]; then
|
|
local STDERR_LINTER_FILE_PATH
|
|
STDERR_LINTER_FILE_PATH="${SUPER_LINTER_PRIVATE_OUTPUT_DIRECTORY_PATH}/super-linter-parallel-stderr-${FILE_TYPE}"
|
|
debug "Saving stderr for ${FILE_TYPE} to ${STDERR_LINTER_FILE_PATH} in case we need it later"
|
|
printf '%s\n' "${STDERR_LINTER_LOG_MESSAGE}" >"${STDERR_LINTER_FILE_PATH}"
|
|
fi
|
|
else
|
|
debug "Stderr for ${FILE_TYPE} is empty"
|
|
fi
|
|
|
|
unset -n FILE_ARRAY
|
|
|
|
endGitHubActionsLogGroup "${FILE_TYPE}"
|
|
}
|
|
|
|
# We need this for parallel
|
|
export -f LintCodebase
|