From daba819f8592eafe96eb30ebe94d89fe6096a06f Mon Sep 17 00:00:00 2001 From: Casey Vega Date: Tue, 21 Jul 2020 12:33:36 -0700 Subject: [PATCH] update linter.sh - remove pub On second thought, I do not like this approach because it's asking `pub` questions it has already answered for each file, coupled with the fact that `|| true` means pub can fail for whatever reason. Looking at the other linters, and looking at the recent bug report in #120 I think it's safe to assume that pub, or any package manager can be called as a first step and then proceed to super lint. --- lib/linter.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/linter.sh b/lib/linter.sh index a4310c38..78092223 100755 --- a/lib/linter.sh +++ b/lib/linter.sh @@ -1388,7 +1388,7 @@ if [ "${VALIDATE_DART}" == "true" ]; then # Lint the Dart files # ####################### # LintCodebase "FILE_TYPE" "LINTER_NAME" "LINTER_CMD" "FILE_TYPES_REGEX" "FILE_ARRAY" - LintCodebase "DART" "dart" "pub get || true && dartanalyzer --fatal-infos --fatal-warnings --options ${DART_LINTER_RULES}" ".*\.\(dart\)\$" "${FILE_ARRAY_DART[@]}" + LintCodebase "DART" "dart" "dartanalyzer --fatal-infos --fatal-warnings --options ${DART_LINTER_RULES}" ".*\.\(dart\)\$" "${FILE_ARRAY_DART[@]}" fi ##################