setup-python/docs/contributors.md

38 lines
2 KiB
Markdown
Raw Normal View History

2019-08-20 10:27:52 -04:00
# Contributors
### Checkin
2019-12-27 11:28:48 -05:00
- Do check in source (`src/`)
- Do check in a single `index.js` file after running `ncc`
- Do not check in `node_modules/`
2019-08-20 10:27:52 -04:00
2019-11-07 15:26:27 -05:00
### NCC
2019-08-20 10:27:52 -04:00
In order to avoid uploading `node_modules/` to the repository, we use [vercel/ncc](https://github.com/vercel/ncc) to create a single `index.js` file that gets saved in `dist/`.
2019-08-20 10:27:52 -04:00
2019-11-07 15:26:27 -05:00
### Developing
2019-12-27 11:26:49 -05:00
If you're developing locally, you can run
```sh
2019-11-07 15:26:27 -05:00
npm install
tsc
2020-04-14 08:54:39 -04:00
ncc build src/setup-python.ts
2019-08-20 10:27:52 -04:00
```
Any files generated using `tsc` will be added to `lib/`, however those files also are not uploaded to the repository and are excluded using `.gitignore`.
2019-11-07 15:26:27 -05:00
During the commit step, Husky will take care of formatting all files with [Prettier](https://github.com/prettier/prettier) (to run manually, use `npm run format`).
2019-11-07 15:26:27 -05:00
### Testing
2019-08-20 10:27:52 -04:00
2019-12-27 11:26:49 -05:00
We ask that you include a link to a successful run that utilizes the changes you are working on. For example, if your changes are in the branch `newAwesomeFeature`, then show an example run that uses `setup-python@newAwesomeFeature` or `my-fork@newAwesomeFeature`. This will help speed up testing and help us confirm that there are no breaking changes or bugs.
2019-12-23 11:05:45 -05:00
### Licensed
This repository uses a tool called [Licensed](https://github.com/github/licensed) to verify third party dependencies. You may need to locally install licensed and run `licensed cache` to update the dependency cache if you install or update a production dependency. If licensed cache is unable to determine the dependency, you may need to modify the cache file yourself to put the correct license. You should still verify the dependency, licensed is a tool to help, but is not a substitute for human review of dependencies.
2019-12-23 11:05:45 -05:00
### Releases
There is a `master` branch where contributor changes are merged into. There are also release branches such as `releases/v1` that are used for tagging (for example the `v1` tag) and publishing new versions of the action. Changes from `master` are periodically merged into a releases branch. You do not need to create any PR that merges changes from master into a releases branch.