From 8c35c6c880f88b29b6448c27ed295bc8578256e7 Mon Sep 17 00:00:00 2001 From: Maxim Lobanov Date: Fri, 21 May 2021 18:28:06 +0300 Subject: [PATCH] Update 0000-caching-dependencies.md --- docs/adrs/0000-caching-dependencies.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/adrs/0000-caching-dependencies.md b/docs/adrs/0000-caching-dependencies.md index 4f9429b6..c8c24c55 100644 --- a/docs/adrs/0000-caching-dependencies.md +++ b/docs/adrs/0000-caching-dependencies.md @@ -11,8 +11,8 @@ See more examples on proper usage in [actions/cache documentation](https://githu Integration of caching functionality into `actions/setup-node` action will bring the following benefits for action users: - Decrease the entry threshold for using the cache for Node.js dependencies and simplify initial configuration - Simplify YAML pipelines because no need additional steps to enable caching +- More users will use cache for Node.js so more customers will have fast builds! -As a result, more users will use the cache for Node.js builds and will be happy with fast builds. As the first stage, we will add support for NPM dependencies caching. We can consider adding the same functionality for Yarn later. We don't persue the goal to provide wide customization of caching in scope of `actions/setup-node` action. The purpose of this integration is covering ~90% of basic use-cases. If user needs flexible customization, we should advice them to use `actions/cache` directly. @@ -23,16 +23,16 @@ We don't persue the goal to provide wide customization of caching in scope of `a - `''` - disable caching (default value) - Potentially, we will be able to extend this input to support Yarn - Cache feature will be disabled by default to make sure that we don't break existing customers. We will consider enabling cache by default in next major release (`v3`) -- Add optional input `package-lock-path` that will allow to specify path to `package.lock.json` file path: - - If input is not defined, action will try to search `package.lock.json` or `yarn.lock` (npm 7.x supports `yarn.lock` files) files in the repository root and throw error if no one is found +- Add optional input `package-lock-path` that will allow to specify path to `package-lock.json` file path: + - If input is not defined, action will try to search `package-lock.json` or `yarn.lock` (npm 7.x supports `yarn.lock` files) files in the repository root and throw error if no one is found - If input contains file path, action will use the specified file - - If input contains folder path, action will try to search `package.lock.json` file in the specified folder + - If input contains folder path, action will try to search `package-lock.json` file in the specified folder - if input contains wildcards (like `**/package-lock.json`), hash of multiple files will be used - The hash of file provided in `package-lock-path` input will be used as cache key (the same approach like [actions/cache](https://github.com/actions/cache/blob/main/examples.md#node---npm) recommends) - The following key cache will be used `${{ runner.os }}-npm-${{ hashFiles('') }}` # Example of real use-cases -Default use case when `package.lock.json` or `yarn.lock` are located in repository root: +Default use case when `package-lock.json` or `yarn.lock` are located in repository root: ```yml steps: - uses: actions/checkout@v2