From ee83abeb358b8a032529f235fa36ecb653e7327d Mon Sep 17 00:00:00 2001
From: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
Date: Tue, 6 Dec 2022 22:17:42 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=8E=A8=20Put=20devpi=20creds=20into=20reu?=
 =?UTF-8?q?sable=20vars=20@=20GHA?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .github/workflows/self-smoke-test-action.yml | 25 +++++++++++++-------
 1 file changed, 17 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/self-smoke-test-action.yml b/.github/workflows/self-smoke-test-action.yml
index 44fb648..1c6c651 100644
--- a/.github/workflows/self-smoke-test-action.yml
+++ b/.github/workflows/self-smoke-test-action.yml
@@ -7,6 +7,9 @@ on:   # yamllint disable-line rule:truthy
   pull_request:
 
 env:
+  devpi-password: abcd1234
+  devpi-username: root
+
   FORCE_COLOR: 1  # Request colored output from CLI tools supporting it
   MYPY_FORCE_COLOR: 1  # MyPy's color enforcement
   PIP_DISABLE_PIP_VERSION_CHECK: 1
@@ -26,11 +29,19 @@ jobs:
   smoke-test:
     runs-on: ubuntu-latest
 
+    env:
+      TWINE_REPOSITORY_URL: >-
+        http://devpi:${{
+          job.services.devpi.ports['3141']
+        }}/${{
+          env.devpi-username
+        }}/public/
+
     services:
       devpi:
         image: muccg/devpi
         env:
-          DEVPI_PASSWORD: abcd1234
+          DEVPI_PASSWORD: ${{ env.devpi-password }}
         ports:
         - 3141
 
@@ -54,17 +65,15 @@ jobs:
     - run: python3 -m build
     - run: twine register dist/*.tar.gz
       env:
-        TWINE_USERNAME: root
-        TWINE_PASSWORD: abcd1234
-        TWINE_REPOSITORY_URL: >-
-          http://localhost:${{ job.services.devpi.ports['3141'] }}/root/public/
+        TWINE_USERNAME: ${{ env.devpi-username }}
+        TWINE_PASSWORD: ${{ env.devpi-password }}
     - uses: actions/checkout@v3
       with:
         path: test
     - uses: ./test
       with:
-        user: root
-        password: abcd1234
-        repository_url: http://devpi:3141/root/public/
+        user: ${{ env.devpi-username }}
+        password: ${{ env.devpi-password }}
+        repository_url: ${{ env.TWINE_REPOSITORY_URL }}
 
 ...