From e0c8376c3a00ff1c28e14f8e66295946f1c516fa Mon Sep 17 00:00:00 2001 From: Marco Ferrari Date: Wed, 8 May 2024 09:52:30 +0200 Subject: [PATCH] ci: remove deployment configuration from ci (#5628) Simplify the CI workflows by skipping GitHub deployments configuration. We don't use deployments in any other place at the moment. --- .github/workflows/cd.yml | 49 ---------------------------------------- .github/workflows/ci.yml | 2 +- 2 files changed, 1 insertion(+), 50 deletions(-) diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml index c9f11251..237afdd0 100644 --- a/.github/workflows/cd.yml +++ b/.github/workflows/cd.yml @@ -17,7 +17,6 @@ jobs: cancel-in-progress: true permissions: contents: read - deployments: write issues: write packages: write strategy: @@ -106,14 +105,6 @@ jobs: username: ${{ github.actor }} password: ${{ secrets.GITHUB_TOKEN }} - - name: Start deployment - uses: bobheadxi/deployments@v1.5.0 - id: deployment - with: - step: start - token: ${{ secrets.GITHUB_TOKEN }} - env: Production - - name: Build and Push Image uses: docker/build-push-action@v5 with: @@ -133,21 +124,6 @@ jobs: ${{ env.CONTAINER_IMAGE_ID }} target: "${{ matrix.images.target }}" - - name: Update deployment - uses: bobheadxi/deployments@v1.5.0 - # We depend on the 'deployment' step outputs, so we can't run this step - # if the 'deployment' step didn't run. This can happen if any step - # before the 'deployment' step fails. That's why 'always()' is not - # suitable here. - if: steps.deployment.conclusion != 'cancelled' && steps.deployment.conclusion != 'skipped' - with: - step: finish - token: ${{ secrets.GITHUB_TOKEN }} - status: ${{ job.status }} - deployment_id: ${{ steps.deployment.outputs.deployment_id }} - env: ${{ steps.deployment.outputs.env }} - env_url: https://github.com/super-linter/super-linter - - name: Create Issue on Failure uses: actions/github-script@v7 if: failure() @@ -174,7 +150,6 @@ jobs: cancel-in-progress: true permissions: contents: write - deployments: write issues: write packages: write pull-requests: write @@ -187,15 +162,6 @@ jobs: manifest-file: .github/release-please/.release-please-manifest.json token: ${{ secrets.GITHUB_TOKEN }} - - name: Start deployment - if: steps.release.outputs.release_created - uses: bobheadxi/deployments@v1.5.0 - id: deployment - with: - step: start - token: ${{ secrets.GITHUB_TOKEN }} - env: Release - - name: Configure release metedata if: steps.release.outputs.release_created # shellcheck disable=SC2062 @@ -264,21 +230,6 @@ jobs: git push --force origin ${{ env.SEMVER_MAJOR_VERSION }} git push --force origin latest - - name: Update deployment - uses: bobheadxi/deployments@v1.5.0 - # We depend on the 'deployment' step outputs, so we can't run this step - # if the 'deployment' step didn't run. This can happen if any step - # before the 'deployment' step fails. That's why 'always()' is not - # suitable here. - if: steps.deployment.conclusion != 'cancelled' && steps.deployment.conclusion != 'skipped' - with: - step: finish - token: ${{ secrets.GITHUB_TOKEN }} - status: ${{ job.status }} - deployment_id: ${{ steps.deployment.outputs.deployment_id }} - env: ${{ steps.deployment.outputs.env }} - env_url: https://github.com/super-linter/super-linter - - name: Create Issue on Failure uses: actions/github-script@v7 if: failure() diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f8611beb..f288a3a9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,7 +14,7 @@ jobs: name: Build and Test runs-on: ubuntu-latest permissions: - contents: read + contents: read concurrency: # Ref: https://docs.github.com/en/actions/learn-github-actions/contexts#github-context # github.head_ref: head_ref or source branch of the pull request