From d6c5203ef694c341ab4e2300d7f26edf7d6e3d3d Mon Sep 17 00:00:00 2001 From: Lucas Gravley <29484535+admiralAwkbar@users.noreply.github.com> Date: Wed, 8 Jan 2020 07:47:23 -0600 Subject: [PATCH] fixing rules --- Dockerfile | 2 +- TEMPLATES/.ruby-lint.yml | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Dockerfile b/Dockerfile index aafea08a..bc301574 100644 --- a/Dockerfile +++ b/Dockerfile @@ -64,7 +64,7 @@ RUN npm -g --no-cache install \ #################### # Run GEM installs # #################### -RUN gem install rubocop +RUN gem install rubocop rubocop-rails ###################### # Install shellcheck # diff --git a/TEMPLATES/.ruby-lint.yml b/TEMPLATES/.ruby-lint.yml index c70ad84d..e904c0a1 100644 --- a/TEMPLATES/.ruby-lint.yml +++ b/TEMPLATES/.ruby-lint.yml @@ -22,10 +22,6 @@ Security/Open: ############################# Metrics Rules #################################### ################################################################################ -# Commonly used screens these days easily fit more than 80 characters. -Metrics/LineLength: - Max: 120 - # Too short methods lead to extraction of single-use methods, which can make # the code easier to read (by naming things), but can also clutter the class Metrics/MethodLength: @@ -73,6 +69,10 @@ Layout/SpaceInsideBlockBraces: Layout/SpaceInsideHashLiteralBraces: EnforcedStyle: no_space +# Commonly used screens these days easily fit more than 80 characters. +Layout/LineLength: + Max: 120 + ################################################################################ ########################### Style Rules ######################################## ################################################################################ @@ -167,7 +167,7 @@ Lint/ShadowingOuterLocalVariable: # Suppressing exceptions can be perfectly fine, and be it to avoid to # explicitly type nil into the rescue since that's what you want to return, # or suppressing LoadError for optional dependencies -Lint/HandleExceptions: +Lint/SuppressedException: Enabled: false Lint/AssignmentInCondition: