From d05f179506ba3d376680f8f2711712214bc75e99 Mon Sep 17 00:00:00 2001 From: Gabo Date: Tue, 11 Aug 2020 21:05:01 -0500 Subject: [PATCH] Add logic to include/exclude linters --- lib/validation.sh | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/lib/validation.sh b/lib/validation.sh index 6e4105b0..c63ea87e 100755 --- a/lib/validation.sh +++ b/lib/validation.sh @@ -57,6 +57,8 @@ function GetValidationInfo() { # Determine if any linters were explicitly set # ################################################ ANY_SET="false" + ANY_TRUE="false" + ANY_FALSE="false" # Loop through all languages for LANGUAGE in "${LANGUAGE_ARRAY[@]}"; do # build the variable @@ -65,12 +67,21 @@ function GetValidationInfo() { if [ -n "${!VALIDATE_LANGUAGE}" ]; then # It was set, need to set flag ANY_SET="true" + if [ "${!VALIDATE_LANGUAGE}" == "true" ]; then + ANY_TRUE="true" + elif [ "${!VALIDATE_LANGUAGE}" == "false" ]; then + ANY_FALSE="true" + fi fi done - ################################################### - # Validate if we should check individual lanuages # - ################################################### + if [ $ANY_TRUE == "true" ] && [ $ANY_FALSE == "true" ]; then + fatal "Behavior not supported, please either only include (VALIDATE=true) or exclude (VALIDATE=false) linters, but not both" + fi + + ######################################################### + # Validate if we should check/omit individual languages # + ######################################################### # Loop through all languages for LANGUAGE in "${LANGUAGE_ARRAY[@]}"; do # build the variable @@ -79,8 +90,10 @@ function GetValidationInfo() { if [[ ${ANY_SET} == "true" ]]; then # Check to see if the variable was set if [ -z "${!VALIDATE_LANGUAGE}" ]; then - # Flag was not set, default to false - eval "${VALIDATE_LANGUAGE}='false'" + # Flag was not set, default to: + # if ANY_TRUE then set to false + # if ANY_FALSE then set to true + eval "${VALIDATE_LANGUAGE}='$ANY_FALSE'" fi else # No linter flags were set - default all to true