From ace79ca4032a39ccd1cc6055e200eb54d982d7b0 Mon Sep 17 00:00:00 2001 From: Marco Ferrari Date: Wed, 31 Jan 2024 10:31:06 +0100 Subject: [PATCH] build: ignore changelog when linting codebase (#5205) CHANGELOG.md is automatically generated by the release workflow. Ignore it when linting the codebase because it might not pass textlint validation because of lowercase terms. --- .github/release-please/release-please-config.json | 10 +++++----- .textlintignore | 6 ------ Makefile | 8 ++++---- 3 files changed, 9 insertions(+), 15 deletions(-) delete mode 100644 .textlintignore diff --git a/.github/release-please/release-please-config.json b/.github/release-please/release-please-config.json index efdb3d10..fa41bb99 100644 --- a/.github/release-please/release-please-config.json +++ b/.github/release-please/release-please-config.json @@ -1,18 +1,18 @@ { "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json", "changelog-sections": [ - { - "section": "⬆️ Dependency updates", - "type": "deps" - }, { "section": "🚀 Features", "type": "feat" }, { - "section": "🐛 Bug fixes", + "section": "🐛 Bugfixes", "type": "fix" }, + { + "section": "⬆️ Dependency updates", + "type": "deps" + }, { "section": "🧰 Maintenance", "type": "build" diff --git a/.textlintignore b/.textlintignore deleted file mode 100644 index cf1461fa..00000000 --- a/.textlintignore +++ /dev/null @@ -1,6 +0,0 @@ -CHANGELOG.md -test/linters/jscpd/good/markdown_good_1.md -test/linters/markdown/markdown_bad_1.md -test/linters/markdown/markdown_bad_1.md -test/linters/markdown/markdown_good_1.md -test/linters/natural_language/bad/natural_language_bad_01.md diff --git a/Makefile b/Makefile index 074e1179..4be93d12 100644 --- a/Makefile +++ b/Makefile @@ -164,7 +164,7 @@ test-git-flags: ## Run super-linter with different git-related flags -e ACTIONS_RUNNER_DEBUG=true \ -e ERROR_ON_MISSING_EXEC_BIT=true \ -e ENABLE_GITHUB_ACTIONS_GROUP_TITLE=true \ - -e FILTER_REGEX_EXCLUDE=".*/test/linters/.*" \ + -e FILTER_REGEX_EXCLUDE=".*(/test/linters/|CHANGELOG.md).*" \ -e DEFAULT_BRANCH=main \ -e IGNORE_GENERATED_FILES=true \ -e IGNORE_GITIGNORED_FILES=true \ @@ -179,7 +179,7 @@ lint-codebase: ## Lint the entire codebase -e ACTIONS_RUNNER_DEBUG=true \ -e DEFAULT_BRANCH=main \ -e ENABLE_GITHUB_ACTIONS_GROUP_TITLE=true \ - -e FILTER_REGEX_EXCLUDE=".*/test/linters/.*" \ + -e FILTER_REGEX_EXCLUDE=".*(/test/linters/|CHANGELOG.md).*" \ -e GITLEAKS_CONFIG_FILE=".gitleaks-ignore-tests.toml" \ -e RENOVATE_SHAREABLE_CONFIG_PRESET_FILE_NAMES="default.json,hoge.json" \ -e VALIDATE_ALL_CODEBASE=true \ @@ -198,7 +198,7 @@ lint-subset-files-enable-only-one-type: ## Lint a small subset of files in the c -e ACTIONS_RUNNER_DEBUG=true \ -e DEFAULT_BRANCH=main \ -e ENABLE_GITHUB_ACTIONS_GROUP_TITLE=true \ - -e FILTER_REGEX_EXCLUDE=".*/test/linters/.*" \ + -e FILTER_REGEX_EXCLUDE=".*(/test/linters/|CHANGELOG.md).*" \ -e VALIDATE_ALL_CODEBASE=true \ -e VALIDATE_MARKDOWN=true \ -v "$(CURDIR):/tmp/lint" \ @@ -211,7 +211,7 @@ lint-subset-files-enable-expensive-io-checks: ## Lint a small subset of files in -e ACTIONS_RUNNER_DEBUG=true \ -e DEFAULT_BRANCH=main \ -e ENABLE_GITHUB_ACTIONS_GROUP_TITLE=true \ - -e FILTER_REGEX_EXCLUDE=".*/test/linters/.*" \ + -e FILTER_REGEX_EXCLUDE=".*(/test/linters/|CHANGELOG.md).*" \ -e VALIDATE_ALL_CODEBASE=true \ -e VALIDATE_ARM=true \ -e VALIDATE_CLOUDFORMATION=true \