From dd84550d46346c156dda935560709af75ce9ceee Mon Sep 17 00:00:00 2001 From: Dana Merrick Date: Thu, 3 Sep 2020 19:23:24 -0400 Subject: [PATCH 1/2] Honoring DISABLE_ERRORS --- lib/linter.sh | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/linter.sh b/lib/linter.sh index 08edb0e6..5a9ec0da 100755 --- a/lib/linter.sh +++ b/lib/linter.sh @@ -988,6 +988,11 @@ CallStatusAPI() { else # Failure MESSAGE="${FAIL_MSG}" + + # make sure we honor DISABLE_ERRORS + if [ "${DISABLE_ERRORS}" == "true" ]; then + STATUS="success" + fi fi ########################################################## From c64c5c8d608b519264efc1a3eb45d6811ed917d6 Mon Sep 17 00:00:00 2001 From: Dana Merrick Date: Thu, 3 Sep 2020 19:37:10 -0400 Subject: [PATCH 2/2] Cleaner solution --- lib/linter.sh | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/linter.sh b/lib/linter.sh index 5a9ec0da..9c24d1e1 100755 --- a/lib/linter.sh +++ b/lib/linter.sh @@ -988,17 +988,18 @@ CallStatusAPI() { else # Failure MESSAGE="${FAIL_MSG}" - - # make sure we honor DISABLE_ERRORS - if [ "${DISABLE_ERRORS}" == "true" ]; then - STATUS="success" - fi fi ########################################################## # Check to see if were enabled for multi Status mesaages # ########################################################## if [ "${MULTI_STATUS}" == "true" ] && [ -n "${GITHUB_TOKEN}" ] && [ -n "${GITHUB_REPOSITORY}" ]; then + + # make sure we honor DISABLE_ERRORS + if [ "${DISABLE_ERRORS}" == "true" ]; then + STATUS="success" + fi + ############################################## # Call the status API to create status check # ##############################################