actions/lint
1
0
Fork 0
mirror of https://github.com/super-linter/super-linter.git synced 2024-12-22 20:52:12 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix OpenAPI tests being run by JSON & YAML

Browse source 
Tests are run by file extension. The [JSON] and [YAML] tests were running the _bad_ [OPENAPI] tests and expecting them to fail.

For [OPENAPI] the _bad_ tests are syntactically good JSON/YAML but bad OAS.
This commit is contained in:
Justin Kalland 2020-06-25 11:49:09 +02:00
parent eac560b35b
commit 37f6828d1e
6 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
.automation/test/openapi/README.md
View file

@ -2,7 +2,8 @@
This folder holds the test cases for **OpenAPI**. This folder holds the test cases for **OpenAPI**.
## Additional Docs ## Additional Docs
No Additional information is needed for this test case. The `_bad_` tests are valid `.yml`/`.json` but invalid OpenAPI specs.
The test extensions used are `.ymlopenapi`/`.jsonopenapi` instead of `.yml`/`.json`. This is to prevent the [YAML] and [JSON] tests from picking them up.
## Good Test Cases ## Good Test Cases
The test cases denoted: `LANGUAGE_good_FILE.EXTENSION` are all valid, and should pass successfully when linted. The test cases denoted: `LANGUAGE_good_FILE.EXTENSION` are all valid, and should pass successfully when linted.

0
.automation/test/openapi/openapi_bad_1.yml → .automation/test/openapi/openapi_bad_1.ymlopenapi
View file

0
.automation/test/openapi/openapi_bad_2.json → .automation/test/openapi/openapi_bad_2.jsonopenapi
View file

0
.automation/test/openapi/openapi_good_1.yml → .automation/test/openapi/openapi_good_1.ymlopenapi
View file

0
.automation/test/openapi/openapi_good_2.json → .automation/test/openapi/openapi_good_2.jsonopenapi
View file

2
lib/linter.sh
View file

@ -2236,7 +2236,7 @@ RunTestCases()
TestCodebase "CSS" "stylelint" "stylelint --config $CSS_LINTER_RULES" ".*\.\(css\)\$" TestCodebase "CSS" "stylelint" "stylelint --config $CSS_LINTER_RULES" ".*\.\(css\)\$"
TestCodebase "ENV" "dotenv-linter" "dotenv-linter" ".*\.\(env\)\$" TestCodebase "ENV" "dotenv-linter" "dotenv-linter" ".*\.\(env\)\$"
TestCodebase "KOTLIN" "ktlint" "ktlint" ".*\.\(kt\|kts\)\$" TestCodebase "KOTLIN" "ktlint" "ktlint" ".*\.\(kt\|kts\)\$"
TestCodebase "OPENAPI" "spectral" "spectral lint -r $OPENAPI_LINTER_RULES" ".*\.\(yml\|yaml\|json\)\$" TestCodebase "OPENAPI" "spectral" "spectral lint -r $OPENAPI_LINTER_RULES" ".*\.\(ymlopenapi\|jsonopenapi\)\$"
################# #################
# Footer prints # # Footer prints #