From 1930e2f9a9e7c3a14ff4b3ba8bb0f7298c7b346b Mon Sep 17 00:00:00 2001 From: Barry Pollard Date: Tue, 14 Sep 2021 14:32:24 +0100 Subject: [PATCH] Correct expressions in GitHub Actions workflows (#1952) * Correct expressions in stale workflow * Fix other workflows * Fix typos Co-authored-by: Lukas Gravley --- .github/workflows/deploy-DEV-slim.yml | 4 ++-- .github/workflows/deploy-DEV-standard.yml | 4 ++-- .github/workflows/deploy-PROD-slim.yml | 2 +- .github/workflows/deploy-PROD-standard.yml | 2 +- .github/workflows/deploy-RELEASE-slim.yml | 8 ++++---- .github/workflows/deploy-RELEASE-standard.yml | 8 ++++---- .github/workflows/stale.yml | 4 ++-- 7 files changed, 16 insertions(+), 16 deletions(-) diff --git a/.github/workflows/deploy-DEV-slim.yml b/.github/workflows/deploy-DEV-slim.yml index 2683c8d8..8de484ca 100644 --- a/.github/workflows/deploy-DEV-slim.yml +++ b/.github/workflows/deploy-DEV-slim.yml @@ -30,8 +30,8 @@ jobs: # Set the agent to run on runs-on: ubuntu-latest # Prevent duplicate run from happening when a forked push is committed - if: ${{ github.event_name }} == 'push' || - ${{ github.event.pull_request.head.repo.full_name }} != ${{ github.repository }} + if: ${{ github.event_name == 'push' || + github.event.pull_request.head.repo.full_name != github.repository }} ################## # Load all steps # ################## diff --git a/.github/workflows/deploy-DEV-standard.yml b/.github/workflows/deploy-DEV-standard.yml index a8342e75..c51d5c18 100644 --- a/.github/workflows/deploy-DEV-standard.yml +++ b/.github/workflows/deploy-DEV-standard.yml @@ -30,8 +30,8 @@ jobs: # Set the agent to run on runs-on: ubuntu-latest # Prevent duplicate run from happening when a forked push is committed - if: ${{ github.event_name }} == 'push' || - ${{ github.event.pull_request.head.repo.full_name }} != ${{ github.repository }} + if: ${{ github.event_name == 'push' || + github.event.pull_request.head.repo.full_name != github.repository }} ################## # Load all steps # ################## diff --git a/.github/workflows/deploy-PROD-slim.yml b/.github/workflows/deploy-PROD-slim.yml index 79f92a1f..dce49cdb 100644 --- a/.github/workflows/deploy-PROD-slim.yml +++ b/.github/workflows/deploy-PROD-slim.yml @@ -29,7 +29,7 @@ jobs: # Set the agent to run on runs-on: ubuntu-latest # Only run this on the main repo - if: ${{ github.repository }} == 'github/super-linter' + if: ${{ github.repository == 'github/super-linter' }} ################## # Load all steps # ################## diff --git a/.github/workflows/deploy-PROD-standard.yml b/.github/workflows/deploy-PROD-standard.yml index 40f47050..cf815846 100644 --- a/.github/workflows/deploy-PROD-standard.yml +++ b/.github/workflows/deploy-PROD-standard.yml @@ -29,7 +29,7 @@ jobs: # Set the agent to run on runs-on: ubuntu-latest # Only run this on the main repo - if: ${{ github.repository }} == 'github/super-linter' + if: ${{ github.repository == 'github/super-linter' }} ################## # Load all steps # ################## diff --git a/.github/workflows/deploy-RELEASE-slim.yml b/.github/workflows/deploy-RELEASE-slim.yml index 265b6f74..f1c296b2 100644 --- a/.github/workflows/deploy-RELEASE-slim.yml +++ b/.github/workflows/deploy-RELEASE-slim.yml @@ -31,10 +31,10 @@ jobs: ##################################################################### # Only run if Admin start job and it was the Release Issue template # ##################################################################### - if: ${{ github.actor }} == 'admiralawkbar' || ${{ github.actor }} == 'jwiebalk' || - ${{ github.actor }} == 'IAmHughes' || ${{ github.actor }} == 'nemchik' || - ${{ github.actor }} == 'Hanse00' || ${{ github.actor }} == 'github-actions' || - ${{ github.actor }} == 'GaboFDC' || ${{ github.actor }} == 'ferrarimarco' + if: ${{ github.actor == 'admiralawkbar' || github.actor == 'jwiebalk' || + github.actor == 'IAmHughes' || github.actor == 'nemchik' || + github.actor == 'Hanse00' || github.actor == 'github-actions' || + github.actor == 'GaboFDC' || github.actor == 'ferrarimarco' }} ################## # Load all steps # diff --git a/.github/workflows/deploy-RELEASE-standard.yml b/.github/workflows/deploy-RELEASE-standard.yml index 47861a99..b36cc84c 100644 --- a/.github/workflows/deploy-RELEASE-standard.yml +++ b/.github/workflows/deploy-RELEASE-standard.yml @@ -31,10 +31,10 @@ jobs: ##################################################################### # Only run if Admin start job and it was the Release Issue template # ##################################################################### - if: ${{ github.actor }} == 'admiralawkbar' || ${{ github.actor }} == 'jwiebalk' || - ${{ github.actor }} == 'IAmHughes' || ${{ github.actor }} == 'nemchik' || - ${{ github.actor }} == 'Hanse00' || ${{ github.actor }} == 'github-actions' || - ${{ github.actor }} == 'GaboFDC' || ${{ github.actor }} == 'ferrarimarco' + if: ${{ github.actor == 'admiralawkbar' || github.actor == 'jwiebalk' || + github.actor == 'IAmHughes' || github.actor == 'nemchik' || + github.actor == 'Hanse00' || github.actor == 'github-actions' || + github.actor == 'GaboFDC' || github.actor == 'ferrarimarco' }} ################## # Load all steps # diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index 7e4407b4..75d60ebf 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -26,7 +26,7 @@ jobs: markstale: runs-on: ubuntu-latest # only run on schedule - if: ${{ github.event_name }} == 'schedule' + if: ${{ github.event_name == 'schedule' }} steps: - name: Mark issue stale uses: actions/stale@v4 @@ -47,7 +47,7 @@ jobs: marknotstale: runs-on: ubuntu-latest # do not run on schedule - if: "${{ github.event_name }} == 'issue_comment' && contains(github.event.issue.labels.*.name, 'O: stale 🤖') && ${{ github.event.issue.user.type }} != 'Bot'" + if: "${{ github.event_name == 'issue_comment' }} && contains(github.event.issue.labels.*.name, 'O: stale 🤖') && ${{ github.event.issue.user.type != 'Bot' }}" steps: - name: Mark issue not stale uses: actions/github-script@v4.1