From 102ceb6a8d60feb91e93a674e48700cc0bbc4c1d Mon Sep 17 00:00:00 2001 From: Marco Ferrari Date: Tue, 26 Nov 2024 16:05:44 +0100 Subject: [PATCH] chore: disable fail-fast in ci (#6399) Don't stop the test suite on test failures, and don't skip reporting failures on certain test failures. --- .github/workflows/ci.yml | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 95a5e339..8e4899f4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -252,14 +252,10 @@ jobs: - set-build-metadata - build-container-image - build-test-suite-matrix - # Don't fail the entire test suite when: - # - Running npm audit, so we can see test results even if there are - # vulnerable dependencies that might be unrelated to the PR - # - Running the 'test' target because it runs all the tests, including the - # ones that are allowed to fail - continue-on-error: ${{ matrix.test-case == 'npm-audit' || matrix.test-case == 'test' }} strategy: - fail-fast: true + # Continue running the rest of the test suite so we get feedback even if + # there are failures in certain tests, such as when running npm-audit + fail-fast: false matrix: test-case: ${{ fromJson(needs.build-test-suite-matrix.outputs.matrix) }} images: