cookies fixes, hook improvement, more porting

This commit is contained in:
Max Leiter 2022-11-09 19:46:12 -08:00
parent 95d1ef31ef
commit cf7d89eb20
31 changed files with 138 additions and 277 deletions

View file

@ -1,67 +1,33 @@
import styles from "@styles/Home.module.css"
import NewPost from "@components/new-post"
import PageSeo from "@components/page-seo"
import { Page } from "@geist-ui/core/dist"
import Head from "next/head"
import { GetServerSideProps } from "next"
import { Post } from "@lib/types"
import cookie from "cookie"
import { useRouter } from "next/navigation"
import { cookies } from "next/headers"
import { TOKEN_COOKIE_NAME } from "@lib/constants"
import { getPostWithFiles } from "app/prisma"
import { useRedirectIfNotAuthed } from "@lib/server/hooks/use-redirect-if-not-authed"
const NewFromExisting = async ({
params
}: {
params: {
id: string
}
}) => {
const { id } = params
const router = useRouter()
const cookieList = cookies()
useRedirectIfNotAuthed()
const driftToken = cookieList.get(TOKEN_COOKIE_NAME)
if (!driftToken) {
return router.push("/signin")
}
const NewFromExisting = async () => {
return (
// <Head>
// {/* TODO: solve this. */}
// {/* eslint-disable-next-line @next/next/no-css-tags */}
// <link rel="stylesheet" href="/css/react-datepicker.css" />
// </Head>
<NewPost initialPost={post} newPostParent={parentId} />
)
if (!id) {
return router.push("/new")
}
const post = await getPostWithFiles(id)
return <NewPost initialPost={post} newPostParent={id} />
}
// export const getServerSideProps: GetServerSideProps = async ({
// req,
// params
// }) => {
// const id = params?.id
// const redirect = {
// redirect: {
// destination: "/new",
// permanent: false
// }
// }
// if (!id) {
// return redirect
// }
// const driftToken = cookie.parse(req.headers.cookie || "")[`drift-token`]
// const post = await fetch(`${process.env.API_URL}/posts/${id}`, {
// method: "GET",
// headers: {
// "Content-Type": "application/json",
// Authorization: `Bearer ${driftToken}`,
// "x-secret-key": process.env.SECRET_KEY || ""
// }
// })
// if (!post.ok) {
// return redirect
// }
// const data = await post.json()
// if (!data) {
// return redirect
// }
// return {
// props: {
// post: data,
// parentId: id
// }
// }
// }
export default NewFromExisting

View file

@ -0,0 +1,4 @@
export default function NewLayout({ children }: { children: React.ReactNode }) {
// useRedirectIfNotAuthed()
return <>{children}</>;
}

View file

@ -1,10 +1,6 @@
import NewPost from "@components/new-post"
import '@styles/react-datepicker.css'
const New = () => {
return (
<NewPost />
)
}
const New = () => <NewPost />
export default New

34
client/app/mine/page.tsx Normal file
View file

@ -0,0 +1,34 @@
import styles from "@styles/Home.module.css"
import MyPosts from "@components/my-posts"
import type { GetServerSideProps } from "next"
import { Post } from "@lib/types"
import { Page } from "@geist-ui/core/dist"
import { getCookie } from "cookies-next"
import { TOKEN_COOKIE_NAME } from "@lib/constants"
import { useRouter } from "next/navigation"
import { cookies } from "next/headers"
export default function Mine() {
const router = useRouter()
const driftToken = cookies().get(TOKEN_COOKIE_NAME)
if (!driftToken) {
return router.push("/signin")
}
// const posts = await fetch(process.env.API_URL + `/posts/mine`, {
// method: "GET",
// headers: {
// "Content-Type": "application/json",
// Authorization: `Bearer ${driftToken}`,
// "x-secret-key": process.env.SECRET_KEY || ""
// }
// })
if (!posts.ok) {
return router.push("/signin")
}
const { posts, error, hasMore } = await posts.json()
return <MyPosts morePosts={hasMore} error={error} posts={posts} />
}

View file

@ -1,4 +1,5 @@
import Cookies from "js-cookie"
import { TOKEN_COOKIE_NAME } from "@lib/constants"
import { getCookie } from "cookies-next"
import styles from "./admin.module.css"
import PostTable from "./post-table"
import UserTable from "./user-table"
@ -14,7 +15,7 @@ export const adminFetcher = async (
method: options?.method || "GET",
headers: {
"Content-Type": "application/json",
Authorization: `Bearer ${Cookies.get("drift-token")}`
Authorization: `Bearer ${getCookie(TOKEN_COOKIE_NAME)}`
},
body: options?.body && JSON.stringify(options.body)
})

View file

@ -10,6 +10,7 @@ import Input from "@components/input"
import Button from "@components/button"
import Note from "@components/note"
import { USER_COOKIE_NAME } from "@lib/constants"
import { setCookie } from "cookies-next"
const NO_EMPTY_SPACE_REGEX = /^\S*$/
const ERROR_MESSAGE =
@ -33,7 +34,7 @@ const Auth = ({
const handleJson = (json: any) => {
signin(json.token)
Cookies.set(USER_COOKIE_NAME, json.userId)
setCookie(USER_COOKIE_NAME, json.userId)
router.push("/new")
}

View file

@ -1,7 +1,8 @@
import PasswordModal from "@components/new-post/password-modal"
import { Button, ButtonGroup, Loading, useToasts } from "@geist-ui/core/dist"
import { TOKEN_COOKIE_NAME } from "@lib/constants"
import type { PostVisibility } from "@lib/types"
import Cookies from "js-cookie"
import { getCookie } from "cookies-next"
import { useCallback, useState } from "react"
type Props = {
@ -21,7 +22,7 @@ const VisibilityControl = ({ postId, visibility, setVisibility }: Props) => {
method: "PUT",
headers: {
"Content-Type": "application/json",
Authorization: `Bearer ${Cookies.get("drift-token")}`
Authorization: `Bearer ${getCookie(TOKEN_COOKIE_NAME)}`
},
body: JSON.stringify({ visibility, password })
})

View file

@ -2,12 +2,11 @@
import { Button, useToasts, Input, ButtonDropdown } from "@geist-ui/core/dist"
import { useRouter } from "next/navigation"
import { useCallback, useEffect, useMemo, useRef, useState } from "react"
import { useCallback, useState } from "react"
import generateUUID from "@lib/generate-uuid"
import FileDropzone from "./drag-and-drop"
import styles from "./post.module.css"
import Title from "./title"
import Cookies from "js-cookie"
import type { PostVisibility, Document as DocumentType } from "@lib/types"
import PasswordModal from "./password-modal"
import EditDocumentList from "@components/edit-document-list"
@ -16,7 +15,8 @@ import DatePicker from "react-datepicker"
import getTitleForPostCopy from "@lib/get-title-for-post-copy"
import Description from "./description"
import { PostWithFiles } from "app/prisma"
import { USER_COOKIE_NAME } from "@lib/constants"
import { TOKEN_COOKIE_NAME, USER_COOKIE_NAME } from "@lib/constants"
import { getCookie } from "cookies-next"
const emptyDoc = {
title: "",
@ -68,7 +68,7 @@ const Post = ({
method: "POST",
headers: {
"Content-Type": "application/json",
Authorization: `Bearer ${Cookies.get("drift-token")}`
Authorization: `Bearer ${getCookie(TOKEN_COOKIE_NAME)}`
},
body: JSON.stringify({
title,
@ -140,12 +140,13 @@ const Post = ({
return
}
const cookieName = getCookie(USER_COOKIE_NAME)
await sendRequest("/api/posts/create", {
title,
files: docs,
visibility,
password,
userId: Cookies.get(USER_COOKIE_NAME) || "",
userId: cookieName ? String(getCookie(USER_COOKIE_NAME)) : "",
expiresAt: expiresAt || null,
parentId: newPostParent
})

View file

@ -5,9 +5,10 @@ import ListItemSkeleton from "./list-item-skeleton"
import ListItem from "./list-item"
import { Post } from "@lib/types"
import { ChangeEvent, useCallback, useEffect, useMemo, useState } from "react"
import Cookies from "js-cookie"
import useDebounce from "@lib/hooks/use-debounce"
import Link from "@components/link"
import { TOKEN_COOKIE_NAME } from "@lib/constants"
import { getCookie } from "cookies-next"
type Props = {
initialPosts: Post[]
@ -32,7 +33,7 @@ const PostList = ({ morePosts, initialPosts, error }: Props) => {
method: "GET",
headers: {
"Content-Type": "application/json",
Authorization: `Bearer ${Cookies.get("drift-token")}`,
Authorization: `Bearer ${getCookie(TOKEN_COOKIE_NAME)}`,
"x-page": `${posts.length / 10 + 1}`
}
})
@ -61,7 +62,7 @@ const PostList = ({ morePosts, initialPosts, error }: Props) => {
method: "GET",
headers: {
"Content-Type": "application/json",
Authorization: `Bearer ${Cookies.get("drift-token")}`
Authorization: `Bearer ${getCookie(TOKEN_COOKIE_NAME)}`
// "tok": process.env.SECRET_KEY || ''
}
}
@ -97,7 +98,7 @@ const PostList = ({ morePosts, initialPosts, error }: Props) => {
method: "DELETE",
headers: {
"Content-Type": "application/json",
Authorization: `Bearer ${Cookies.get("drift-token")}`
Authorization: `Bearer ${getCookie(TOKEN_COOKIE_NAME)}`
}
})

View file

@ -15,10 +15,10 @@ import ScrollToTop from "@components/scroll-to-top"
import { useRouter } from "next/router"
import ExpirationBadge from "@components/badges/expiration-badge"
import CreatedAgoBadge from "@components/badges/created-ago-badge"
import Cookies from "js-cookie"
import PasswordModalPage from "./password-modal-wrapper"
import VisibilityControl from "@components/badges/visibility-control"
import { USER_COOKIE_NAME } from "@lib/constants"
import { getCookie } from "cookies-next"
type Props = {
post: Post
@ -33,7 +33,7 @@ const PostPage = ({ post: initialPost, isProtected }: Props) => {
)
const [isLoading, setIsLoading] = useState(true)
const [isOwner] = useState(
post.users ? post.users[0].id === Cookies.get(USER_COOKIE_NAME) : false
post.users ? post.users[0].id === getCookie(USER_COOKIE_NAME) : false
)
const router = useRouter()
const isMobile = useMediaQuery("mobile")

View file

@ -1,3 +1,4 @@
import { getCookie } from "cookies-next"
import Cookies from "js-cookie"
import { memo, useEffect, useState } from "react"
import styles from "./preview.module.css"
@ -35,7 +36,7 @@ const MarkdownPreview = ({ height = 500, fileId, content, title }: Props) => {
method: "GET",
headers: {
"Content-Type": "application/json",
Authorization: `Bearer ${Cookies.get("drift-token") || ""}`
Authorization: `Bearer ${getCookie("drift-token")}`
},
})

View file

@ -1,4 +1,6 @@
import { Input, Button, useToasts } from "@geist-ui/core/dist"
import { TOKEN_COOKIE_NAME } from "@lib/constants"
import { getCookie } from "cookies-next"
import Cookies from "js-cookie"
import { useState } from "react"
@ -43,7 +45,7 @@ const Password = () => {
method: "PUT",
headers: {
"Content-Type": "application/json",
Authorization: `Bearer ${Cookies.get("drift-token")}`
Authorization: `Bearer ${getCookie(TOKEN_COOKIE_NAME)}`
},
body: JSON.stringify({
oldPassword: password,

View file

@ -1,5 +1,7 @@
import { Note, Input, Textarea, Button, useToasts } from "@geist-ui/core/dist"
import { TOKEN_COOKIE_NAME } from "@lib/constants"
import useUserData from "@lib/hooks/use-user-data"
import { getCookie } from "cookies-next"
import Cookies from "js-cookie"
import { useEffect, useState } from "react"
@ -50,7 +52,7 @@ const Profile = () => {
method: "PUT",
headers: {
"Content-Type": "application/json",
Authorization: `Bearer ${Cookies.get("drift-token")}`
Authorization: `Bearer ${getCookie(TOKEN_COOKIE_NAME)}`
},
body: JSON.stringify(data)
})

View file

@ -9,6 +9,7 @@ const useSignedIn = () => {
"signedIn",
typeof window === "undefined" ? false : !!token
)
const signin = (token: string) => {
setSignedIn(true)
// TODO: investigate SameSite / CORS cookie security

View file

@ -1,25 +1,26 @@
import { User } from "@lib/types"
import Cookies from "js-cookie"
import { deleteCookie, getCookie } from "cookies-next"
import { useRouter } from "next/navigation"
import { useEffect, useState } from "react"
const useUserData = () => {
const cookie = getCookie("drift-token")
const [authToken, setAuthToken] = useState<string>(
Cookies.get("drift-token") || ""
cookie ? String(cookie) : ""
)
const [user, setUser] = useState<User>()
const router = useRouter()
useEffect(() => {
const token = Cookies.get("drift-token")
const token = getCookie("drift-token")
if (token) {
setAuthToken(token)
setAuthToken(String(token))
}
}, [setAuthToken])
useEffect(() => {
if (authToken) {
const fetchUser = async () => {
const response = await fetch(`/server-api/user/self`, {
const response = await fetch(`/api/user/self`, {
headers: {
Authorization: `Bearer ${authToken}`
}
@ -28,7 +29,7 @@ const useUserData = () => {
const user = await response.json()
setUser(user)
} else {
Cookies.remove("drift-token")
deleteCookie("drift-token")
setAuthToken("")
router.push("/")
}

View file

@ -1,60 +0,0 @@
"use client";
import clsx from "clsx";
import type {
ChangeEventHandler,
FunctionComponent,
PropsWithChildren,
} from "react";
import Cookies from "js-cookie";
import React, { useContext, useState, createContext } from "react";
import { DEFAULT_THEME, Theme, THEME_COOKIE_NAME } from "./theme";
const ThemeContext = createContext<Theme | null>(null);
export function useTheme(): Theme {
return useContext(ThemeContext);
}
interface Props extends PropsWithChildren {
defaultTheme: Theme;
}
const ThemeClientContextProvider: FunctionComponent<Props> = ({
defaultTheme,
children,
}) => {
const [theme, setTheme] = useState<Theme>(defaultTheme);
const onChange: ChangeEventHandler<HTMLSelectElement> = (e) => {
const value = e.target.value as Theme;
setTheme(value);
if (value === DEFAULT_THEME) {
Cookies.remove(THEME_COOKIE_NAME);
} else {
Cookies.set(THEME_COOKIE_NAME, value);
}
};
const onReset = () => {
setTheme(DEFAULT_THEME);
Cookies.remove(THEME_COOKIE_NAME);
};
return (
<div className={clsx(theme === "dark" && "dark")}>
<div className="mb-2">
<h2 className="mb-2 font-bold text-xl">Theme Switcher</h2>
<select value={theme} onChange={onChange} className="mr-2 inline-block">
<option value="light">Light</option>
<option value="dark">Dark</option>
</select>
<button className="bg-gray-300 p-2" onClick={onReset}>
Reset
</button>
</div>
<ThemeContext.Provider value={theme}>{children}</ThemeContext.Provider>
</div>
);
};
export default ThemeClientContextProvider;

View file

@ -1,27 +0,0 @@
import { FunctionComponent, PropsWithChildren } from "react";
import ThemeClientContextProvider from "./ThemeClientContextProvider";
import ThemeServerContextProvider, {
useServerTheme,
} from "./ThemeServerContextProvider";
const ThemeProviderWrapper: FunctionComponent<PropsWithChildren> = ({
children,
}) => {
const theme = useServerTheme();
return (
<ThemeClientContextProvider defaultTheme={theme}>
{children}
</ThemeClientContextProvider>
);
};
const ThemeProvider: FunctionComponent<PropsWithChildren> = ({ children }) => {
return (
<ThemeServerContextProvider>
<ThemeProviderWrapper>{children}</ThemeProviderWrapper>
</ThemeServerContextProvider>
);
};
export default ThemeProvider;

View file

@ -1,25 +0,0 @@
import type { FunctionComponent, PropsWithChildren } from "react";
// @ts-ignore -- createServerContext is not in @types/react atm
import { useContext, createServerContext } from "react";
import { cookies } from "next/headers";
import { Theme, THEME_COOKIE_NAME } from "./theme";
import { DEFAULT_THEME } from "./theme";
const ThemeContext = createServerContext<Theme | null>(null);
export function useServerTheme(): Theme {
return useContext(ThemeContext);
}
const ThemeServerContextProvider: FunctionComponent<PropsWithChildren> = ({
children,
}) => {
const cookiesList = cookies();
const theme = cookiesList.get(THEME_COOKIE_NAME) ?? DEFAULT_THEME;
return (
<ThemeContext.Provider value={theme}>{children}</ThemeContext.Provider>
);
};
export default ThemeServerContextProvider;

View file

@ -9,7 +9,7 @@ export async function generateAndExpireAccessToken(userId: User["id"]) {
await prisma.authTokens.create({
data: {
userId: userId,
token: token
token: token,
}
})

View file

@ -0,0 +1,12 @@
import { useRouter } from 'next/navigation'
import { isSignedIn } from "../is-signed-in"
export const useRedirectIfNotAuthed = (to = '/signin') => {
const router = useRouter();
const signedIn = isSignedIn();
if (!signedIn) {
router.push(to);
}
}

View file

@ -0,0 +1,6 @@
import { cookies } from "next/headers"
export const isSignedIn = () => {
const cookieList = cookies()
return cookieList.has("drift-token") && cookieList.has("drift-userid")
}

View file

@ -1,7 +1,7 @@
import { NextApiRequest, NextApiResponse } from "next"
import prisma from "app/prisma"
import bcrypt from "bcrypt"
import { signin } from "@lib/api/signin"
import { signin } from "@lib/server/signin"
export default async function handler(
req: NextApiRequest,

View file

@ -2,7 +2,7 @@ import config from "@lib/config"
import { NextApiRequest, NextApiResponse } from "next"
import prisma from "app/prisma"
import bcrypt, { genSalt } from "bcrypt"
import { generateAndExpireAccessToken } from "@lib/api/generate-access-token"
import { generateAndExpireAccessToken } from "@lib/server/generate-access-token"
export default async function handler(
req: NextApiRequest,
@ -35,7 +35,7 @@ export default async function handler(
},
})
const token = await generateAndExpireAccessToken(user)
const token = await generateAndExpireAccessToken(user.id)
return res.status(201).json({ token: token, userId: user.id })
}

View file

@ -1,5 +1,5 @@
import getHtmlFromFile from "@lib/api/get-html-from-drift-file"
import { parseUrlQuery } from "@lib/api/parse-url-query"
import getHtmlFromFile from "@lib/server/get-html-from-drift-file"
import { parseUrlQuery } from "@lib/server/parse-url-query"
import prisma from "app/prisma"
import { NextApiRequest, NextApiResponse } from "next"

View file

@ -0,0 +1,11 @@
import prisma from "app/prisma"
export const getPostsByUser = async (userId: number) => {
const posts = await prisma.post.findMany({
where: {
}
})
return posts
}

View file

@ -13,7 +13,6 @@ export const getWelcomeContent = async () => {
console.log(introContent)
return {
title: introTitle,
content: introContent,

View file

@ -1,67 +0,0 @@
import styles from "@styles/Home.module.css"
import Header from "@components/header"
import MyPosts from "@components/my-posts"
import cookie from "cookie"
import type { GetServerSideProps } from "next"
import { Post } from "@lib/types"
import { Page } from "@geist-ui/core/dist"
const Home = ({
morePosts,
posts,
error
}: {
morePosts: boolean
posts: Post[]
error: boolean
}) => {
return (
<Page className={styles.wrapper}>
<Page.Content className={styles.main}>
<MyPosts morePosts={morePosts} error={error} posts={posts} />
</Page.Content>
</Page>
)
}
// get server side props
export const getServerSideProps: GetServerSideProps = async ({ req }) => {
const driftToken = cookie.parse(req.headers.cookie || "")[`drift-token`]
if (!driftToken) {
return {
redirect: {
destination: "/",
permanent: false
}
}
}
const posts = await fetch(process.env.API_URL + `/posts/mine`, {
method: "GET",
headers: {
"Content-Type": "application/json",
Authorization: `Bearer ${driftToken}`,
"x-secret-key": process.env.SECRET_KEY || ""
}
})
if (!posts.ok) {
return {
redirect: {
destination: "/",
permanent: false
}
}
}
const data = await posts.json()
return {
props: {
posts: data.posts,
error: posts.status !== 200,
morePosts: data.hasMore
}
}
}
export default Home